manifest: Skip non-directories when resolving workspace members
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If globs provided in the `members` array resolve to files, even if none of its results are (symlinks to) directories or if the path is a relative path to a file without any globbing directives, `cargo` skips it without error. Cargo only errors out if the glob (or again relative path) didn't resolve to any files at all (which is what `glob::glob()` should also be doing for us). It does however support symlinks, meaning we need to canonicalize every result to follow any symlinks before deducing if the entry is a directory that needs to be treated as a workspace member crate.
MarijnS95
force-pushed
the
workspace-members-skip-non-directories
branch
from
be36a4d to
c6d4721
Compare
MarijnS95
commented
Nov 29, 2024
| @@ -11,6 +11,6 @@ pub use args::Args; | |||
| pub use artifact::{Artifact, ArtifactType}; | |||
| pub use config::{EnvError, EnvOption, LocalizedConfig}; | |||
| pub use error::Error; | |||
| pub use manifest::CrateType; | |||
| pub use manifest::{CrateType, Manifest}; | |||
There was a problem hiding this comment.
Getting complains that one field is not read inside Manifest -> Workspace. We don't expose any public API with Manifest yet but might as well export it.
Or should we mark it all pub(crate)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
If globs provided in the
membersarray resolve to files, even if none of its results are (symlinks to) directories or if the path is a relative path to a file without any globbing directives,cargoskips it without error. Cargo only errors out if the glob (or again relative path) didn't resolve to any files at all (which is whatglob::glob()should also be doing for us).It does however support symlinks, meaning we need to canonicalize every result to follow any symlinks before deducing if the entry is a directory that needs to be treated as a workspace member crate.